Simplify kompilation for proof tests#2430
Merged
rv-jenkins merged 5 commits intomasterfrom May 20, 2024
Merged
Conversation
tothtamas28
changed the title
geo2a
reviewed
May 20, 2024
kevm-pyk/src/tests/conftest.py
Outdated
| parser.addoption( | ||
| '--kompiled-targets-dir', | ||
| type=dir_path, | ||
| '--kompiled-target-dir', |
Contributor
There was a problem hiding this comment.
May I ask you to not change this name, as our performance script uses the old one?
geo2a
reviewed
May 20, 2024
| ids=[str(spec_file.relative_to(SPEC_DIR)) for spec_file in ALL_TESTS], | ||
| ) | ||
| def test_kompile_targets(spec_file: Path, kompiled_target_for: Callable[[Path], Path], request: FixtureRequest) -> None: | ||
| def test_kompile( |
Contributor
There was a problem hiding this comment.
Same request as above, would it be possible to not change this name too?
geo2a
suggested changes
May 20, 2024
Contributor
geo2a
left a comment
geo2a
left a comment
There was a problem hiding this comment.
Please do not change the names of the command line arguments and the test that prekompiles the defintions.
tothtamas28
force-pushed
the
kompile-cache
branch
from
9af6777 to
82cbc9f
Compare
tothtamas28
force-pushed
the
kompile-cache
branch
from
5d6049c to
6e2539e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2419
kompiled_target_cachefixture--kompiled-targets-dirto exist